Card grid for desktop reveal and single-pick dialogs#10646
Open
MostCromulent wants to merge 1 commit intoCard-Forge:masterfrom
Open
Card grid for desktop reveal and single-pick dialogs#10646MostCromulent wants to merge 1 commit intoCard-Forge:masterfrom
MostCromulent wants to merge 1 commit intoCard-Forge:masterfrom
Conversation
Replace the text-list dialogs that desktop matches use for reveal and single-card pick prompts (opponent reveals their hand, look at top N of library, choose a card from a list) with a thumbnail grid. Cards are visual objects; players recognise them by art faster than by name. Dispatch lives inline in ListChooser: when the list is CardView-only and maxChoices <= 1, build a CardImageGrid; otherwise the existing text path runs unchanged. CardImageGrid is genericized over the item type with a small per-type adapter for image-key and footer-text resolution, so the deck-editor art picker continues to use it for PaperCards while in-game dialogs use it for CardViews. Multi-card prompts continue to route through DualListBox. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Example using Inquisition of Kozilek
Before:
After:
CardImageGridas a general utility for the deck-editor art picker; this PR takes advantage of it for desktop reveal and single-pick dialogs, so reveal/discard/exile prompts show thumbnails instead of a names-only list.CardImageGridis now generic over the item type via aCellAdapter;forPaperCardskeeps the deck-editor art picker,forCardViewsis the new in-match path.CardViewListChooserdialogs (counter types, colors, modes, spell abilities) stay on the text list — there's no card art to render.CardViewselection isn't part ofListChoosertraffic at all — it routes throughDualListBox(two-column ordering) orInputSelectCardsFromList(clicking cards on the battlefield), which are separate widgets with their own UX. Bringing the grid look to those is a larger change and out of scope here.🤖 Generated with Claude Code